-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Remove disabling of Agent e2e tests because of 6331 #6611
[e2e] Remove disabling of Agent e2e tests because of 6331 #6611
Conversation
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
Isn't this also fixed in |
buildkite test this -f p=gke,E2E_TAGS=agent,BUILD_LICENSE_PUBKEY=dev -m s=8.7.0-SNAPSHOT,s=8.8.0-SNAPSHOT |
From this comment I assumed 8.8.0-SNAPSHOT @thbkrkr but maybe I'm wrong? |
Indeed, it's confusing. I assumed My test with
|
@thbkrkr I'll go ahead and adjust to 8.7.0-snap and run a set of tests, and we'll see... |
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
It's good in --- PASS: TestFleetMode (378.83s)
--- PASS: TestSystemIntegrationRecipe (154.15s)
--- PASS: TestKubernetesIntegrationRecipe (114.68s)
--- PASS: TestMultiOutputRecipe (288.36s)
--- PASS: TestFleetKubernetesIntegrationRecipe (384.84s)
--- PASS: TestFleetCustomLogsIntegrationRecipe (273.16s)
--- PASS: TestFleetAPMIntegrationRecipe (275.64s)
--- PASS: TestFleetAgentWithoutTLS (364.27s) You can trigger with |
buildkite test this -f p=gke,t=TestFleet,BUILD_LICENSE_PUBKEY=dev -m s=8.7.0-SNAPSHOT,s=8.8.0-SNAPSHOT |
@thbkrkr all tests passed with 8.7 so I'd say we leave it there.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e-87-testfleet.xml:name="TestFleetMode" time="348.160000">
e2e-87-testfleet.xml:name="TestFleetKubernetesIntegrationRecipe" time="375.720000">
e2e-87-testfleet.xml:name="TestFleetCustomLogsIntegrationRecipe" time="344.520000">
e2e-87-testfleet.xml:name="TestFleetAPMIntegrationRecipe" time="359.780000">
e2e-87-testfleet.xml:name="TestFleetAgentWithoutTLS" time="401.400000">
e2e-88-testfleet.xml:name="TestFleetMode" time="368.290000">
e2e-88-testfleet.xml:name="TestFleetKubernetesIntegrationRecipe" time="340.400000">
e2e-88-testfleet.xml:name="TestFleetCustomLogsIntegrationRecipe" time="377.040000">
e2e-88-testfleet.xml:name="TestFleetAPMIntegrationRecipe" time="352.830000">
e2e-88-testfleet.xml:name="TestFleetAgentWithoutTLS" time="288.850000">
* Remove disabling of agent e2e tests because of 6331. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
* Remove disabling of agent e2e tests because of 6331. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
* Remove disabling of agent e2e tests because of 6331. Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
closes #6331
Since issue from 6331 has been resolved, and is included in
8.8.0-SNAPSHOT
, go ahead and remove the disabling of the Agent e2e tests and do not run them on8.6.0 <= Agent stack < 8.8.0-SNAPSHOT
(Please someone double check my logic below, as I believe
MinFor
includes pre-release/snapshot)